fix: nonhybrid granite model id#546
Open
guicho271828 wants to merge 3 commits intogenerative-computing:mainfrom
Open
fix: nonhybrid granite model id#546guicho271828 wants to merge 3 commits intogenerative-computing:mainfrom
guicho271828 wants to merge 3 commits intogenerative-computing:mainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
reviewed
Feb 17, 2026
Contributor
jakelorocco
left a comment
There was a problem hiding this comment.
A test is failing:
test/cli/test_alora_train_integration.py::test_alora_training_integration
We probably shouldn't be running this test in CICD: #538.
But it appears to only be failing for your branch; please investigate why your changes cause this behavior or make sure the test passes locally and ensure remaining tests pass as well.
jakelorocco
approved these changes
Feb 18, 2026
51f0b40 to
11eb0fb
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
* fix: granite for non-hybrid model id * feat: granite4 nano model family (1b, 350m) * fix: skip alora training test on CICD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
IBM_GRANITE_4_MICRO_3Bpoints to the hybrid model #534Testing