Skip to content

fix: nonhybrid granite model id#546

Open
guicho271828 wants to merge 3 commits intogenerative-computing:mainfrom
guicho271828:fix-nonhybrid-granite-model-id
Open

fix: nonhybrid granite model id#546
guicho271828 wants to merge 3 commits intogenerative-computing:mainfrom
guicho271828:fix-nonhybrid-granite-model-id

Conversation

@guicho271828
Copy link
Contributor

@guicho271828 guicho271828 commented Feb 16, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@guicho271828 guicho271828 requested a review from a team as a code owner February 16, 2026 13:35
@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Feb 16, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@guicho271828 guicho271828 changed the title Fix nonhybrid granite model fix: nonhybrid granite model id Feb 16, 2026
Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing:

test/cli/test_alora_train_integration.py::test_alora_training_integration

We probably shouldn't be running this test in CICD: #538.

But it appears to only be failing for your branch; please investigate why your changes cause this behavior or make sure the test passes locally and ensure remaining tests pass as well.

@guicho271828 guicho271828 force-pushed the fix-nonhybrid-granite-model-id branch from 51f0b40 to 11eb0fb Compare February 18, 2026 14:33
@guicho271828 guicho271828 added this pull request to the merge queue Feb 18, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2026
* fix: granite for non-hybrid model id

* feat: granite4 nano model family (1b, 350m)

* fix: skip alora training test on CICD
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments