Skip to content

Fix/popover#67

Merged
Aunshon merged 3 commits intomainfrom
fix/popover
Mar 6, 2026
Merged

Fix/popover#67
Aunshon merged 3 commits intomainfrom
fix/popover

Conversation

@Aunshon
Copy link
Collaborator

@Aunshon Aunshon commented Mar 6, 2026

Summary by CodeRabbit

  • Documentation

    • Added Storybook stories for the Sheet component demonstrating basic form interactions, multi-directional slide-ins (top/right/bottom/left), and custom close button implementations.
  • New Features

    • Expanded the Popover API by exposing PopoverClose and PopoverArrow components for improved customization options.

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@Aunshon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8738bbbc-f67d-46ec-9629-bbcdbd9d15a1

📥 Commits

Reviewing files that changed from the base of the PR and between 77c07d2 and 92c5675.

📒 Files selected for processing (1)
  • src/components/ui/Sheet.stories.tsx
📝 Walkthrough

Walkthrough

This pull request adds a new Storybook story file demonstrating the Sheet component with three interactive examples (basic sheet, multi-sided sheets, and sheet without close button), and expands the public API by exporting PopoverClose and PopoverArrow from the UI component indices.

Changes

Cohort / File(s) Summary
Sheet Component Stories
src/components/ui/Sheet.stories.tsx
New Storybook file with three story examples: Default (basic sheet with form fields), Sides (sheets from all directions), and NoCloseButton (custom close implementation). Includes meta configuration with autodocs and centered layout.
Component Exports
src/components/ui/index.ts, src/index.ts
Added PopoverClose and PopoverArrow exports, making these Popover subcomponents available in the public UI API.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A sheet unfolds in stories three,
Each side and state for all to see!
Popovers whisper, close and dart,
Exports bloom—a generous heart! 📚✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix/popover' is vague and generic, using non-descriptive branch naming convention rather than clearly summarizing the actual changes made in the pull request. Revise the title to clearly describe the main changes, such as 'Add PopoverClose and PopoverArrow exports and Sheet component stories' or 'Expand Popover and Sheet component public API with new exports and stories'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/popover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/ui/Sheet.stories.tsx`:
- Around line 26-28: The SheetDescription text contains an unescaped apostrophe
("you're") triggering react/no-unescaped-entities; update the JSX in the
SheetDescription element to remove or escape the apostrophe—for example, reword
"Click save when you're done." to "Click save when you are done." within the
SheetDescription component so the lint rule no longer fails (locate the
SheetDescription JSX in Sheet.stories.tsx to apply the change).
- Line 2: Remove the unused import of useState from the top of the
Sheet.stories.tsx file: delete the token `useState` from the import line
(`import { useState } from "react";`) so the file only imports what it actually
uses (or remove the entire import if no other React named imports remain);
ensure no other code references `useState` after the change to satisfy the
no-unused-vars lint rule.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: da12a3c8-22c9-4c63-8a9e-dcfd63b07e73

📥 Commits

Reviewing files that changed from the base of the PR and between e225feb and 77c07d2.

📒 Files selected for processing (3)
  • src/components/ui/Sheet.stories.tsx
  • src/components/ui/index.ts
  • src/index.ts

@Aunshon Aunshon merged commit eb6c3e7 into main Mar 6, 2026
@Aunshon Aunshon deleted the fix/popover branch March 6, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant