feat(tracing): add child spans to Swift symbol aggregation#575
Merged
Conversation
Adds demangle and aggregate child spans inside SwiftSymbolTypeAggregator.aggregate_symbols to identify where time is spent during slow traces. The span descriptions include symbol counts for additional context. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NicoHinderling
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
demangleandaggregatechild spans insideSwiftSymbolTypeAggregator.aggregate_symbolsto break down where time is spent during slow traces.We observed traces where
aggregate_symbolstakes ~277s but had no visibility into whether the bottleneck is cwl-demangle subprocess calls or the in-memory grouping loop. These spans will show the split in the next trace so we can target the right optimization.Span descriptions include symbol counts (e.g. "cwl_demangle 200000 symbols") for quick context.
🤖 Generated with Claude Code