ref(server): Reduce size of item headers struct#5671
Open
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/slimify-items2
branch
from
eacf74a to
46305f6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/slimify-items2
branch
from
46305f6 to
6b85afb
Compare
Dav1dde
force-pushed
the
dav1d/slimify-items2
branch
2 times, most recently
from
44f5a2c to
cbfe51f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Dav1dde
force-pushed
the
dav1d/slimify-items2
branch
from
cbfe51f to
3d37592
Compare
Dav1dde
force-pushed
the
dav1d/slimify-items2
branch
from
3d37592 to
562b7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the size of the item headers struct by (de-)serializing on demand.
Some leftover fields are fields which are not serialized, we can either also serialize them or some of them can already be removed in a follow-up.
A nice simplification is that,
ContentTypeandAttachmentTypeare nowCopy. In another follow-up the item type can also be moved into theinnervalue andUnknown(String)changed toUnknown.Without any further changes this reduces the
ItemHeaderssize from 320 bytes to 128.