Skip to content

chore: Utilize app-runner for WebGL#2572

Open
bitsandfoxes wants to merge 82 commits intomainfrom
feat/app-runner-webgl
Open

chore: Utilize app-runner for WebGL#2572
bitsandfoxes wants to merge 82 commits intomainfrom
feat/app-runner-webgl

Conversation

@bitsandfoxes
Copy link
Contributor

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Base automatically changed from chore/desktop-integration-test to main March 5, 2026 15:58
# Conflicts:
#	.github/workflows/ci.yml
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Collaborator

@tustanivsky tustanivsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


BeforeAll {
# Run integration test action via WebGL (HTTP server + headless Chrome)
function Invoke-TestAction {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this logic could be moved to a separate WebGL device provider in the app-runner module. This would allow launching the web app with a single Invoke-DeviceApp call and could also be useful for the Godot SDK which currently lacks web integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants