fix: Added build cache path for symbol upload when targeting Switch#2580
Open
bitsandfoxes wants to merge 3 commits intomainfrom
Open
fix: Added build cache path for symbol upload when targeting Switch#2580bitsandfoxes wants to merge 3 commits intomainfrom
bitsandfoxes wants to merge 3 commits intomainfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: AddPath call missing required arguments
- Changed AddPath(beePath) to AddPath(paths, beePath, logger) to provide all required arguments
- ✅ Fixed: Bee cache path uses wrong base directory
- Changed buildOutputDir to projectDir when constructing the Bee cache path since Library folder is at project root
Or push these changes by commenting:
@cursor push 6955aa6806
Preview (6955aa6806)
diff --git a/src/Sentry.Unity.Editor/Native/BuildPostProcess.cs b/src/Sentry.Unity.Editor/Native/BuildPostProcess.cs
--- a/src/Sentry.Unity.Editor/Native/BuildPostProcess.cs
+++ b/src/Sentry.Unity.Editor/Native/BuildPostProcess.cs
@@ -322,8 +322,8 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar
}
// When exporting as an NSP the assemblies are bundled inside the package. So we're also checking the build cache.
- var beePath = Path.Combine(buildOutputDir, "Library", "Bee", "artifacts", "SwitchPlayerBuildProgram");
- AddPath(beePath);
+ var beePath = Path.Combine(projectDir, "Library", "Bee", "artifacts", "SwitchPlayerBuildProgram");
+ AddPath(paths, beePath, logger);
// User-provided Sentry plugin
AddPath(paths, Path.GetFullPath("Assets/Plugins/Sentry/"), logger);
@@ -322,8 +322,8 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar
}
// When exporting as an NSP the assemblies are bundled inside the package. So we're also checking the build cache.
- var beePath = Path.Combine(buildOutputDir, "Library", "Bee", "artifacts", "SwitchPlayerBuildProgram");
- AddPath(beePath);
+ var beePath = Path.Combine(projectDir, "Library", "Bee", "artifacts", "SwitchPlayerBuildProgram");
+ AddPath(paths, beePath, logger);
// User-provided Sentry plugin
AddPath(paths, Path.GetFullPath("Assets/Plugins/Sentry/"), logger);This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exporting an actual rom the assemblies are bundled inside the package, causing the symbol upload to fail.