improvement for readCSV file and code refactoring#53
Open
Virous77 wants to merge 1 commit intogitdagray:mainfrom
Open
improvement for readCSV file and code refactoring#53Virous77 wants to merge 1 commit intogitdagray:mainfrom
Virous77 wants to merge 1 commit intogitdagray:mainfrom
Conversation
Virous77
commented
Dec 23, 2023
- Used fs/promises for promise-based file operations.
- Improved the construction of the beginSQLInsert statement.
- Extracted the validation logic into a separate function (validateRow).
- Refactored file existence check into a separate function.
- Added .nvmrc file
|
Hey could you modify your vscode settings so that no unnecessary settings like single quotes to double or tab spaces appear? That ways, it is helpful to check exact changes🙂 |
Author
sure will look into that:) |
jsvigneshkanna
approved these changes
Dec 24, 2023
jsvigneshkanna
approved these changes
Dec 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.