Open
Conversation
Many C++ projects that have their own memory management systems. This is especially the case for games (which often have their own scripting system, which would like to make use of a DAP library to debug them). Often times these games will redefine `free` via a macro to invoke their own memory mangement functions. If `free()` gets defined as a macro, attempting to compile `any.h` will cause the compiler to explode. I note that this is a private function that is only used within `any.h` and it's only used twice, so this should not create any API compatibility issues.
Contributor
Author
|
@dneto0 any chance of this being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many C++ projects have their own memory management systems. This is especially the case for games (which often have their own scripting system, which would like to make use of a DAP library to debug them). Often times these games will redefine
freevia a macro to invoke their own memory mangement functions. Iffree()gets defined as a macro, attempting to compileany.hwill cause the compiler to explode.I note that this is a private function that is only used within
any.hand it's only used twice, so this should not create any API compatibility issues.