Fixes issue with the search input box always taking the user to default language page#1904
Open
cjyabraham wants to merge 1 commit intogoogle:mainfrom
Open
Fixes issue with the search input box always taking the user to default language page#1904cjyabraham wants to merge 1 commit intogoogle:mainfrom
cjyabraham wants to merge 1 commit intogoogle:mainfrom
Conversation
…efault language search results (google#1558) Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Thanks for this PR @cjyabraham. FYI, this is still on the radar. I'll add it as a candidate to release 0.11.0 (#1944). Docsy 0.10.0 is just hot off the press! 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with the search input box always taking the user to the default language search results (#1558)
The problem was that the js script had no knowledge of the current language and so always redirected the user to the default language page. Here I'm passing the correct search results page in to the script from a data element on the search input box.