set db.query.text OpenTelemetry attribute#2061
Open
Kludex wants to merge 3 commits intogoogleapis:mainfrom
Open
set db.query.text OpenTelemetry attribute#2061Kludex wants to merge 3 commits intogoogleapis:mainfrom
db.query.text OpenTelemetry attribute#2061Kludex wants to merge 3 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: s
Kludex
commented
Nov 15, 2024
| TEST_SPAN_ATTRIBUTES = {"foo": "baz"} | ||
|
|
||
|
|
||
| @pytest.mark.skipif(opentelemetry is None, reason="Require `opentelemetry`") |
Author
There was a problem hiding this comment.
It's not possible to add marks to fixtures, this was wrong.
Kludex
commented
Nov 15, 2024
Comment on lines
+162
to
+164
| query = getattr(job_ref, "query", None) | ||
| if query is not None: | ||
| job_attributes["db.query.text"] = query |
Author
There was a problem hiding this comment.
"query" is only available when the job is a QueryJob.
Author
|
I've signed CLA. |
yoshi-kokoro
removed
the
kokoro:run
product-auto-label
bot
added
size: xs
Kludex
changed the title
db.query.text OpenTelemetry attributedb.query.text OpenTelemetry attribute
Linchin
added
the
do not merge
|
PLEASE can we get this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db.query.textattribute to the spans? #2042