Fix norm16 formats to be unfilterable-float and not float#4594
Fix norm16 formats to be unfilterable-float and not float#4594Kangz merged 2 commits intogpuweb:mainfrom
Conversation
|
Results for build job (at d14632e): -webgpu:shader,execution,expression,call,builtin,textureGather:sampled_2d_coords:* - 9342 cases, 37368 subcases (~4/case)
-webgpu:shader,execution,expression,call,builtin,textureGather:sampled_3d_coords:* - 1557 cases, 9342 subcases (~6/case)
-webgpu:shader,execution,expression,call,builtin,textureGather:sampled_array_2d_coords:* - 9342 cases, 149472 subcases (~16/case)
-webgpu:shader,execution,expression,call,builtin,textureGather:sampled_array_3d_coords:* - 1557 cases, 18684 subcases (~12/case)
+webgpu:shader,execution,expression,call,builtin,textureGather:sampled_2d_coords:* - 9018 cases, 36072 subcases (~4/case)
+webgpu:shader,execution,expression,call,builtin,textureGather:sampled_3d_coords:* - 1503 cases, 9018 subcases (~6/case)
+webgpu:shader,execution,expression,call,builtin,textureGather:sampled_array_2d_coords:* - 9018 cases, 144288 subcases (~16/case)
+webgpu:shader,execution,expression,call,builtin,textureGather:sampled_array_3d_coords:* - 1503 cases, 18036 subcases (~12/case)
-webgpu:shader,execution,expression,call,builtin,textureSample:sampled_2d_coords:* - 2754 cases, 5508 subcases (~2/case)
-webgpu:shader,execution,expression,call,builtin,textureSample:sampled_2d_coords,lodClamp:* - 153 cases, 1530 subcases (~10/case)
-webgpu:shader,execution,expression,call,builtin,textureSample:sampled_3d_coords:* - 12393 cases, 28917 subcases (~2/case)
+webgpu:shader,execution,expression,call,builtin,textureSample:sampled_2d_coords:* - 2646 cases, 5292 subcases (~2/case)
+webgpu:shader,execution,expression,call,builtin,textureSample:sampled_2d_coords,lodClamp:* - 147 cases, 1470 subcases (~10/case)
+webgpu:shader,execution,expression,call,builtin,textureSample:sampled_3d_coords:* - 11907 cases, 27783 subcases (~2/case)
-webgpu:shader,execution,expression,call,builtin,textureSample:sampled_array_2d_coords:* - 2754 cases, 22032 subcases (~8/case)
-webgpu:shader,execution,expression,call,builtin,textureSample:sampled_array_3d_coords:* - 459 cases, 2754 subcases (~6/case)
+webgpu:shader,execution,expression,call,builtin,textureSample:sampled_array_2d_coords:* - 2646 cases, 21168 subcases (~8/case)
+webgpu:shader,execution,expression,call,builtin,textureSample:sampled_array_3d_coords:* - 441 cases, 2646 subcases (~6/case)
[snip - full report in action logs]
-TOTAL: 286015 cases, 2345083 subcases
+TOTAL: 280573 cases, 2321497 subcases |
d9d7f66 to
caff7ef
Compare
greggman
left a comment
There was a problem hiding this comment.
This is fine as it adds the correct checks for filterable but it resolvable isn't handled. See isTextureFormatResolable.
Do you want me to clean that up in another PR or you want to do it in this one or...?
|
Thanks, I forgot about resolvability, I'll fix my Dawn CL, but it doesn't make more tests fail: it seems resolvability is already specified correctly in Edit: I got confused, the Dawn CL was already ok. |
|
@toji FYI this will cause additional of suppressions in the next CTS roll, but they will be resolved by https://dawn-review.git.corp.google.com/c/dawn/+/291135 |
|
We do test them here: And they correctly fail validation in Chrome |
Passes locally after fixes in Dawn with dawn.node.
Issue: #4593 but doesn't fix it totally as there were missing validation tests as well.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.