Skip to content

Add chained and compound swizzle assignment tests#4596

Merged
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:compound-and-chained-swizzle
Feb 18, 2026
Merged

Add chained and compound swizzle assignment tests#4596
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:compound-and-chained-swizzle

Conversation

@sudonatalie
Copy link
Contributor

The compound swizzle assignment tests are passing with the WIP dawn implementation at: https://dawn-review.googlesource.com/c/dawn/+/290357

Chained swizzle assignment is not yet implemented.

Issue: #4579


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Results for build job (at f09941a):

-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 13 cases, 104 subcases (~8/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
-webgpu:shader,execution,statement,swizzle_assignment:swizzle_compound_assignment:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_vars:* - 16 cases, 128 subcases (~8/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_compound_assignment:* - 4 cases, 32 subcases (~8/case)
-TOTAL: 280573 cases, 2321497 subcases
+TOTAL: 280578 cases, 2321551 subcases

@sudonatalie sudonatalie force-pushed the compound-and-chained-swizzle branch from e0ba85b to 5d842b5 Compare February 17, 2026 14:59
@sudonatalie sudonatalie force-pushed the compound-and-chained-swizzle branch from 5d842b5 to 9b49d93 Compare February 17, 2026 20:23
@sudonatalie sudonatalie force-pushed the compound-and-chained-swizzle branch from 9b49d93 to f09941a Compare February 18, 2026 21:57
@sudonatalie sudonatalie enabled auto-merge (squash) February 18, 2026 21:57
@sudonatalie sudonatalie merged commit 1b938b5 into gpuweb:main Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments