Skip to content

Add invalid swizzle assignment validation#4598

Merged
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:invalid-swizzles
Feb 19, 2026
Merged

Add invalid swizzle assignment validation#4598
sudonatalie merged 1 commit intogpuweb:mainfrom
sudonatalie:invalid-swizzles

Conversation

@sudonatalie
Copy link
Contributor

These tests pass with the WIP implementation of swizzle assignment in dawn. This is the last set of tests for the swizzle assignment language feature.

Issue: #4579


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@sudonatalie sudonatalie requested a review from dj2 February 19, 2026 00:44
@github-actions
Copy link

Results for build job (at 3ebf801):

+webgpu:shader,validation,statement,swizzle_assignment:invalid_mixed_letter_schemes:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,validation,statement,swizzle_assignment:invalid_address_of_swizzle_view:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,validation,statement,swizzle_assignment:invalid_index_into_swizzle_view:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 280578 cases, 2321551 subcases
+TOTAL: 280581 cases, 2321554 subcases

@sudonatalie sudonatalie merged commit 49f76dc into gpuweb:main Feb 19, 2026
1 check passed
@sudonatalie sudonatalie deleted the invalid-swizzles branch February 19, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments