Add check for node build (no building in the entire branch)#966
Merged
SlimaneAmar merged 2 commits intomainfrom Mar 16, 2026
Merged
Add check for node build (no building in the entire branch)#966SlimaneAmar merged 2 commits intomainfrom
SlimaneAmar merged 2 commits intomainfrom
Conversation
SlimaneAmar
force-pushed
the
add_assert_for_build
branch
from
9d6fe98 to
299db89
Compare
SlimaneAmar
force-pushed
the
add_assert_for_build
branch
from
299db89 to
51b2b7b
Compare
sBouzols
reviewed
Mar 16, 2026
src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
Outdated
Show resolved
Hide resolved
sBouzols
reviewed
Mar 16, 2026
src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
Outdated
Show resolved
Hide resolved
sBouzols
reviewed
Mar 16, 2026
|
|
||
| " SELECT n.id_node, n.parent_node " + | ||
| " FROM NODE n " + | ||
| " INNER JOIN NodeHierarchy nh ON n.id_node = nh.parent_node AND n.type != 'ROOT'" + |
Contributor
Author
There was a problem hiding this comment.
I think it's unnecessary because there's no join
sBouzols
reviewed
Mar 16, 2026
| @Parameter(description = "nodeUuid") @PathVariable("nodeUuid") UUID nodeUuid, | ||
| @RequestHeader(HEADER_USER_ID) String userId) { | ||
| studyService.assertNoBlockedNodeInTree(nodeUuid, rootNetworkUuid); | ||
| studyService.assertCanBuildNode(rootNetworkUuid, nodeUuid); |
Contributor
There was a problem hiding this comment.
Agreeing together.
Do not protect every usage of studyService.buildNode.
This fix the main user means of creation the related issue
|
sBouzols
approved these changes
Mar 16, 2026
Contributor
sBouzols
left a comment
sBouzols
left a comment
There was a problem hiding this comment.
Code Review OK
Tests OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary