Draft
Conversation
TODO: Add tests
Member
Author
|
@kannanjgithub, I added you as you may want to pre-review, before the gRFC is finalized. I'm really only expecting bikeshedding on the label name (as part of the gRFC). This is introducing a new stable API, so take a special look at the Grpc class. |
Contributor
|
Thanks for putting this up. Changes look good. |
ejona86
added
TODO:release blocker
The existing tests really liked to use inconsistent CallOptions in the same test.
shivaspeaks
reviewed
Dec 28, 2025
| if (module.customLabelEnabled) { | ||
| builder.put( | ||
| CUSTOM_LABEL_KEY, info.getCallOptions().getOption(Grpc.CALL_OPTION_CUSTOM_LABEL)); | ||
| } |
Member
There was a problem hiding this comment.
I see that javadoc for CALL_OPTION_CUSTOM_LABEL mentions "must not be set to null", however if an application developer inadvertently passes null using withOption, and here it will pass that null directly to the OpenTelemetry AttributesBuilder.put() method. Should we do an explicit null check here?
Member
There was a problem hiding this comment.
Or use of Strings.nullToEmpty().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Add tests
I've created this so I can reference it as an example from gRFC A108.