Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry#12608
Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry#12608jdcormie wants to merge 4 commits intogrpc:masterfrom
Conversation
ejona86
left a comment
There was a problem hiding this comment.
Ugh. That's annoying for so small a usage. But it all makes sense.
FWIW, we've been moving things to testFixtures over time, since those are never shipped to users (and users have used some of our internal test utilities). So api/src/testFixtures would have been a bit better, but it's not that big of a deal and can be changed later.
OK moved it to api/src/testFixtures |
|
PTAL? I tested this internally as CR/862431843 and it seems to work. |
|
Friendly ping? If you want this done in some other way just LMK! |
|
Eric is OOO and will be back on Monday. |
Will not squash.