netty: Propagate initial handshake failure before close#12626
Open
becomeStar wants to merge 1 commit intogrpc:masterfrom
Open
netty: Propagate initial handshake failure before close#12626becomeStar wants to merge 1 commit intogrpc:masterfrom
becomeStar wants to merge 1 commit intogrpc:masterfrom
Conversation
When a handshake failure occurs before any writes are buffered on the server side, WriteBufferingAndExceptionHandler can record the failure internally but never surface it to downstream inbound handlers. This makes the original handshake error unobservable and complicates debugging and instrumentation. Propagate only the first failure via exceptionCaught, gated on the absence of a previous failure, so that the canonical error becomes observable while avoiding duplicate propagation and preserving existing close semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handshake failures that occur before any writes are buffered can currently be lost to downstream inbound handlers. In this case, the failure is surfaced via the write / promise path, but exceptionCaught is never observed by handlers placed after WriteBufferingAndExceptionHandler.
This makes the original handshake error difficult to diagnose and inconsistent with failures that occur after buffering has started.
This change propagates the exception via fireExceptionCaught before closing the channel when handling the first failure on an active channel. Doing so preserves the original failure while the pipeline is still intact and avoids losing the
exception due to close-triggered teardown or reentrancy.
Fixes #8495