This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Open
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Author
|
I signed it |
|
@stanley-cheung could you please review? |
|
@srini100 @stanley-cheung ping on this review. can we move forward? |
hsaliak
reviewed
Apr 8, 2019
| $ brew install homebrew/homebrew-core/php@7.1 | ||
| $ echo 'export PATH="/usr/local/opt/php@7.1/bin:$PATH"' >> ~/.zshrc | ||
| $ echo 'export PATH="/usr/local/opt/php@7.1/sbin:$PATH"' >> ~/.zshrc | ||
| $ source ~/.zshrc |
There was a problem hiding this comment.
zsh is a non standard shell. Is this really required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want to merge into grpc/grpc master branch FROM jerrycmh/grpc fork,jerry_php_mac_instruction branch.
Update instructions for install php on macOs