Conversation
Suffers infinite recursion due to the QuickCheck override.
The cabal.project file has constraints on hashable and semigroups that mean we need newer versions when doing `cabal v2-*` builds. This commit adds those constraints, as well as a flag to disable them when not using `cabal v2-*`.
This is already being done for `aeson-1.4.3.0` and saves us bumping the aeson version in our nix.
Contributor
|
@ajmcmiddlin We could easily pin with the setup that I uploaded by pinning in default.nix. I actually deliberately decided NOT to pin (in the overlay would be fine to pin in default.nix) because this is a library that is presumably used by many different people, who might want to pin to different versions of nixpkgs themselves. The overlay is generally useful enough that I think people will be able to use it with somewhat different versions of nixpkgs, and it automatically plugs in nicely with existing nix setups. |
Author
|
Yeah, that all makes sense. I'll use your setup and maybe raise a PR for taking nixpkgs as an argument in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on #380 I (with the help of some team mates) updated the nix setup. @IvanMalison updated the nix setup before I cleaned up my changes and put them in a PR. I thought I should still raise this version, as it takes a different approach that may be preferable.
The key difference here is that
nixpkgsis (by default) pinned to a specific commit, such that this setup should always work regardless of the user'sNIX_PATH(where<nixpkgs>comes from).I've tested this with both
nix-buildandnix-shell --run "cabal v2-build github".