Use prettyprinter instead of ansi-wl-pprint#77
Use prettyprinter instead of ansi-wl-pprint#77jasagredo wants to merge 1 commit intohaskellari:masterfrom
Conversation
| import qualified Data.Primitive as Prim | ||
|
|
||
| #if MIN_VERSION_base(4,9,0) | ||
| #if MIN_VERSION_base(4,17,0) |
There was a problem hiding this comment.
I'm unsure if I was doing something weird, but this module seems to only exist in base >=4.17, that's why I updated this cpp
There was a problem hiding this comment.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
There was a problem hiding this comment.
I won't accept this change as such. It's a breaking change.
I have thought about how to do this and the streps are:
- add
prettyprinterdependency (behind a manual flag) and functionality similarly how there are printers usingprettyandansi-wl-pprint. - make
ansi-wl-pprintdependency behind a flag too (enabled) - make
ansi-wl-pprintflag disabled by default. Later, as that will be a breaking change.
But I'm unsure about this. Maybe I won't do flags, but rather a companion packages.
| import qualified Data.Primitive as Prim | ||
|
|
||
| #if MIN_VERSION_base(4,9,0) | ||
| #if MIN_VERSION_base(4,17,0) |
There was a problem hiding this comment.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
|
Any way to move forward on this? The rest of the ecosystem has moved on but |
What you mean by that? |
|
@phadej See #91, an upstream change in
The only way to fix this is by using |
I didn't do anything fancy, just "inlining" what I found in
prettyprinter-compat-ansi-wl-pprint.