ci: run clippy, docs and fmt checks on stable#756
Merged
yoshuawuyts merged 1 commit intohttp-rs:mainfrom Dec 18, 2020
Merged
Conversation
mendelt
force-pushed
the
run_checks_on_stable
branch
from
1b378ce to
4e3c5b9
Compare
Contributor
Author
|
I just noticed this has 100% overlap with #736 which even does a bit more. I'll leave this pr open for now but if 736 is merged this can be closed. |
I think this ran on nightly because clippy needed that. I'm pretty sure clippy runs fine on stable now.
mendelt
changed the title
yoshuawuyts
approved these changes
Dec 18, 2020
Member
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
#736 is currently failing; I believe it can be rebased on this PR if required, and we do need to fix some of these things. With that in mind I'm going to go ahead and merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build was failing for a while because clippy, doc-tests and cargo fmt are run on rust nightly. Unfortunately the nightly build does not always include all these components. In this case cargo fmt was failing.
It used to be necessary to run clippy on nightly so I assume this is why these steps were run on nightly for the Tide build. This is not necessary anymore. This pr changes the build script to run these steps on rust stable.