Draft
Conversation
Author
|
link issue #308 |
Author
|
Hi @iddan, I've come across another repository that uses classes to define selected and editing states in order to prevent floating problems during selection. You can find it at https://nadbm.github.io/react-datasheet/. What are your thoughts on this solution? |
Owner
|
Hey @becory thank you so much for your work. I'm in a very busy period in my life. Unfortunately, I can't assist with it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @iddan,
I hope you're having a great day! I've been working with this amazing component to develop an Excel viewer, but I've encountered an issue. It seems that there isn't a merge cell feature available when using this component.
I've been attempting to create a custom component, and during this process, I noticed that the dimension state is split by both rows and columns. This makes it quite challenging to implement cell merging, as the cells are not tied to specific rows and columns. Consequently, it's not possible to use the row and column index to obtain the real dimensions of the table.
To address this, I merged two states and used ":" in the key to specify which column should utilize this dimension. I've also created a test for the CustomMergeCell component in Storybook to ensure that the feature works as intended and achieves the desired result.
I've come across a bug in this PR that I'm currently working hard to resolve:
The dimensions seem to be misaligned with cell positions when users zoom in and out of the page.
I'm still in the process of testing for other potential bugs.
I'm eagerly awaiting your reply and any assistance you can provide.
Thank you very much.
Wayne