fix(NOISSUE-0000): Infinite refresh loop when session has RefreshTokenError#2796
Open
fix(NOISSUE-0000): Infinite refresh loop when session has RefreshTokenError#2796
RefreshTokenError#2796Conversation
|
View your CI Pipeline Execution ↗ for commit daad55e
☁️ Nx Cloud last updated this comment at |
RefreshTokenErrorRefreshTokenError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users with an expired or revoked refresh token were stuck in an infinite loop on the home page, with the console repeatedly logging:
The proactive token refresh effect in useImmutableSession was responsible:
When a refresh fails, the server sets
session.error = 'RefreshTokenError'and rewrites the JWT — which updatessession.accessTokenExpiresas a side effect of signing the token. That new value triggered the effect again, which calledupdate()again, which failed again, repeating indefinitely.Each retry cycle caused
isAuthenticatedto briefly flicker during the loading phase, which causedWalletProviderto re-invokeconnectWallet→ which calledgetUser()→ which logged the warning.Fix
Added an early-return guard and tracked session?.error in the dependency array:
Adding
session?.errorto the dep array also ensures that if the error later clears (e.g. user re-authenticates in the same session lifecycle), the effect re-evaluates and background refreshes resume correctly.Impact
No change in behaviour for any happy-path scenario. The guard only activates when the server has explicitly flagged a session error, in which case retrying silently was already guaranteed to fail.