feat: add deadline tracking to block submission #220
+66
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a configurable deadline for bundle submission to Flashbots. Submissions that complete before the deadline log success at info level. Submissions that complete after the deadline log warnings to alert that the submission may be too late. New configuration: - SUBMIT_DEADLINE_BUFFER: ms before slot end by which submission must complete (default: 500ms) New metrics: - signet.builder.flashbots.deadline_met: successful submissions within deadline - signet.builder.flashbots.deadline_missed: submissions that missed the deadline Closes ENG-1640
init4samwise
requested review from
Evalir,
dylanlott and
prestwich
as code owners
prestwich
reviewed
Feb 12, 2026
src/tasks/submit/flashbots.rs
Outdated
| // Check if we met the submission deadline | ||
| let met_deadline = Instant::now() <= deadline; | ||
|
|
||
| match response { |
Member
There was a problem hiding this comment.
unnest all this code. avoid if blocks in match arms
Author
There was a problem hiding this comment.
Done - refactored to tuple matching (response, met_deadline) with 4 flat arms. No more nested ifs in match arms.
prestwich
requested changes
Feb 12, 2026
Address PR review feedback: use tuple matching on (response, met_deadline) instead of nested if/else blocks inside match arms. This flattens the code structure while preserving all functionality.
Author
|
Addressed the review feedback - refactored to use tuple matching Commit: 14a63ac |
Adds the missing submit_deadline_buffer field to the test BuilderConfig in test_utils.rs, using the same default value (500ms) as defined in the main config.
Author
|
Fixed the CI failure - added the missing Summary of changes in this PR:
Ready for re-review once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable deadline for bundle submission to Flashbots. Submissions that complete before the deadline log success at info level. Submissions that complete after the deadline log warnings to alert that the submission may be too late.
Related Issues
Closes ENG-1640
Type of Change
Changes
SUBMIT_DEADLINE_BUFFER(default 500ms) - the number of milliseconds before slot end by which submission must completecalculate_submit_deadline()method to FlashbotsTask that computes the deadline similar to how the simulation task doessignet.builder.flashbots.deadline_metandsignet.builder.flashbots.deadline_missedTesting
Checklist
cargo clippy(pending CI)cargo test) (pending CI)