Open
Conversation
- Add test-flashbots Makefile target that runs ignored integration tests - Add flashbots-ci.yml workflow that runs on push to main and PRs - Uses nextest with --run-ignored=only to run flashbots integration tests Closes ENG-1300
init4samwise
requested review from
Evalir,
dylanlott and
prestwich
as code owners
dylanlott
requested changes
Feb 13, 2026
Contributor
dylanlott
left a comment
dylanlott
left a comment
There was a problem hiding this comment.
This should be a triggerable job in Github Actions, but should not be added to the main CI pipeline. The Flashbots integrations tests are too flaky to be in the hot path. Also not sure if they still pass post-Fusaka.
Addresses review feedback - flashbots integration tests are too flaky for the main CI pipeline. Changed to workflow_dispatch so tests can be triggered manually when needed. Added optional 'ref' input to allow testing specific branches/commits.
Contributor
Author
|
Thanks for the review @dylanlott! Good call - I've updated the workflow to use Also added an optional Re: post-Fusaka compatibility - that's a good point. We can run the workflow manually once this is merged to verify current state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
make test-flashbotscommand to the Builder CI pipeline.Changes
test-flashbotstarget that runscargo nextest run --run-ignored=only --workspaceto execute all ignored integration testsTesting
The workflow installs cargo-nextest and Foundry, then runs the integration tests that are currently marked with
#[ignore]annotations.Closes ENG-1300