Jnj templates scripts 1 change rtf decimals#216
Open
munoztd0 wants to merge 2 commits intojnj_templates_scriptsfrom
Open
Jnj templates scripts 1 change rtf decimals#216munoztd0 wants to merge 2 commits intojnj_templates_scriptsfrom
munoztd0 wants to merge 2 commits intojnj_templates_scriptsfrom
Conversation
Contributor
Unit Tests Summary 1 files 274 suites 22m 37s ⏱️ Results for commit 61d51b9. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit feb326d ♻️ This comment has been updated with latest results. |
Contributor
|
how was jjcsformat_count_fraction defined? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here in #209
Since the Shiny reviewer is local-only, I’ve also added the diff-checker link so you can see the exact line-by-line rtf changes.
Summary of changes:
The Change: Changed the format of a calculation in one of the template (tsids01) from one decimal to two decimals.

The Impact: