Open
Conversation
CagriYonca
force-pushed
the
internal-spans
branch
2 times, most recently
from
36fd507 to
a06c130
Compare
CagriYonca
force-pushed
the
internal-spans
branch
from
a06c130 to
1256757
Compare
GSVarsha
reviewed
Feb 23, 2026
CagriYonca
changed the title
CagriYonca
force-pushed
the
internal-spans
branch
4 times, most recently
from
27a05d9 to
f583dd9
Compare
pvital
requested changes
Mar 3, 2026
| return span_filters | ||
| else: | ||
| return [] | ||
| return {} |
Member
There was a problem hiding this comment.
The "default" return of parse_filtered_endpoints() is a list, so I think it's interesting to keep the same here.
Contributor
Author
There was a problem hiding this comment.
In the old ignore-endpoints we kept rules inside a list. Here in span filters, we keep it as a dictionary, so it seems better to use the default value as a dictionary.
What do you say, @pvital ?
Member
There was a problem hiding this comment.
Then, please, adapt the code to reflect the new changes correctly.
…ltering mechanism Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
internal-spans
branch
from
f583dd9 to
55c1a45
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.