Open
Conversation
Signed-off-by: Carl Zhang <carl.zhang@intel.com>
uartie
approved these changes
Jun 27, 2022
evelikov
reviewed
Dec 16, 2022
| VAProfileAV1Profile0, | ||
| VAProfileAV1Profile1, | ||
| VAProfileHEVCSccMain444_10, | ||
| VAProfileProtected, |
There was a problem hiding this comment.
Greetings team,
Was browsing through the tests and noticed this PR. Here are some comments to hopefully push it forward.
Seems like this should be split in three patches and enhanced as follows:
- the HEVC entries should also be added to
g_vaHEVCProfilesjust below VAProfileAV1Profile0andVAProfileAV1Profile1should be added tog_vaAV1Profiles, which then ought to be used in the respective testsVAProfileProtected- same comments as AV1 apply
Hope that helps o/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Zhang carl.zhang@intel.com