Separate HTTP basic auth from JWT auth in README#7
Open
martinlowinski wants to merge 2 commits intointerledgerjs:masterfrom
Open
Separate HTTP basic auth from JWT auth in README#7martinlowinski wants to merge 2 commits intointerledgerjs:masterfrom
martinlowinski wants to merge 2 commits intointerledgerjs:masterfrom
Conversation
sharafian
requested changes
Aug 15, 2019
sharafian
left a comment
sharafian
left a comment
There was a problem hiding this comment.
Can you comment out the secret: line? It's helpful to show what the field would be, but someone reading this might assume they need to set both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While creating a peering with Xpring, I adapted the example configuration from the README. This example however uses JWT and not HTTP basic auth as I thought. Can we change the README a little bit such that this difference becomes more obvious?