Skip to content

Add a code fix for adding missing seq before {…}#1333

Closed
edgarfgp wants to merge 3 commits intoionide:mainfrom
edgarfgp:add-missing-seq-fix
Closed

Add a code fix for adding missing seq before {…}#1333
edgarfgp wants to merge 3 commits intoionide:mainfrom
edgarfgp:add-missing-seq-fix

Conversation

@edgarfgp
Copy link
Contributor

Fixes #1330

@github-actions
Copy link
Contributor

🤖 This is an automated response from Repo Assist.

Hi @edgarfgp! This draft PR has been open since December 2024 — just checking in to see if you're still working on it or would like help completing it. The related issue (#1330) is still open, so the feature would be a welcome addition when ready.

Let us know if there's anything blocking progress or if you'd like a hand!

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@0d6e8cf9db90470cd5477c6a40b350fd9f9e1422. View source at https://github.com/githubnext/agentics/tree/0d6e8cf9db90470cd5477c6a40b350fd9f9e1422/workflows/repo-assist.md.

@Krzysztof-Cieslak
Copy link
Member

/repo-assist figure out what is wrong with the CI, fix it, rebase the changes on main, and create new PR with all the changes

@github-actions
Copy link
Contributor

Pull request created: #1474

Generated by Repo Assist

@github-actions
Copy link
Contributor

🤖 This is an automated response from Repo Assist.

I've analyzed the CI failures in this PR and created a rebased version that fixes them.

Root cause of CI failures:

  • src/FsAutoComplete/CodeFixes/AddMissingSeq.fs needs formatting
  • src/FsAutoComplete/LspServers/AdaptiveServerState.fs needs formatting

The Fantomas formatter check was failing on both files. Additionally, the branch was behind main (missing the AddMissingWildcardOperatorTests addition).

I've created a new PR with:

  1. The changes rebased on the current main
  2. Merge conflict in Tests.fs resolved
  3. dotnet fantomas applied to fix formatting

The new PR builds cleanly. Credit for the implementation remains with you, @edgarfgp — this is just a rebase + format fix.

You can close this PR in favour of the new one if you'd like!

Generated by Repo Assist for issue #1333

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@f2c5cf1e4af58e09a93ba0703c6bf084711b265f. View source at https://github.com/githubnext/agentics/tree/f2c5cf1e4af58e09a93ba0703c6bf084711b265f/workflows/repo-assist.md.

@Krzysztof-Cieslak
Copy link
Member

Will be merged as #1474

Krzysztof-Cieslak pushed a commit that referenced this pull request Feb 26, 2026
fixes #1333 CI) (#1474)

* Add a code fix for adding missing seq before {…}

* more tests

* { start..step..finish }

* fix: apply fantomas formatting to AddMissingSeq code fix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Edgar Gonzalez <egonzalez@totallymoney.com>
Co-authored-by: Repo Assist <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a code fix for adding missing seq before {…}

2 participants