Draft
Conversation
Add `std::optional<evmc_revision> eof_since` to the `instr::traits` with the information in which EVM revision an instruction has become valid in EOF. Using `std::optional` has some inconvenience: the `std::nullopt` is less-than any concrete value (think "Frontier-1") while for undefined instructions we rather want to assign +infinity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 94.29% 94.30%
=======================================
Files 144 144
Lines 16155 16159 +4
=======================================
+ Hits 15234 15238 +4
Misses 921 921
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can guess that the jumpdest analysis is not needed by inspecting the first opcode. This heuristic has some false negatives but is very cheap and covers EOF. The proof it is correct is done at compile-time.
Bigger idea behind this is to only use the heuristic not to waste time on jumpdest analysis and delay EOF header parsing until execution. This makes the code analysis EVM revision agnostic. Maybe someone can push this idea further.