fix MC-197260 causing armorstand preview within smithing table screen to render dark#525
Open
MrKinau wants to merge 1 commit intoisXander:1.21.11from
Open
fix MC-197260 causing armorstand preview within smithing table screen to render dark#525MrKinau wants to merge 1 commit intoisXander:1.21.11from
MrKinau wants to merge 1 commit intoisXander:1.21.11from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the fix for MC-197260 where the armor stand preview within the smithing table screen renders dark.
I could not find a nice way to distinguish between a normal armor stand and this preview, thats why I just skipped the lightCoords update if it's already set to full brightness.
I was not able to build it without changing some javadocs in https://github.com/isXander/Debugify/blob/1.21.10/src/main/java/dev/isxander/debugify/fixes/OS.java#L6 to
{@link net.minecraft.util.Util.OS}, have not included in the PR, as I don't know if it is just a me-issue.