Not all servers support every parameter transmission method#53
Closed
lann wants to merge 1 commit intojoestump:masterfrom
Closed
Not all servers support every parameter transmission method#53lann wants to merge 1 commit intojoestump:masterfrom
lann wants to merge 1 commit intojoestump:masterfrom
Conversation
…hich forces a parameter transmission method
Owner
|
@lann thanks for the PR! @jaitaiwan and I have taken over maintaining this. We're going to try and get a solid update out the door and are going through all of the PRs. Any chance you have tests for this in a fork somewhere? I think this is similar to the work in #124. |
Author
|
Wow this is old! I don't even recall writing this code, so I think it's safe to say there are no tests... |
Owner
|
Haha, no worries. Thanks for replying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some servers don't support all three parameter transmission methods defined in the RFC.
Branch adds a parameter_method argument to both
Client.__init__andClient.requestwhich can force a particular method: "body", "query", or "header". The default behavior is still to auto-pick one of these methods, as before.(New pull request against parameter_method instead of master.)