Conversation
✅ Deploy Preview for react-sync-board ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrmi
left a comment
jrmi
left a comment
There was a problem hiding this comment.
Hey @dynaman216 I made a first review of your job. First I want to thank you for your contribution. I can see you look more comfortable with React now 😉
I left a few comments and questions, I'd love to hear your thoughts about that.
Let me know if you need more details.
| ...translateFn({ | ||
| translateX: prev.translateX, | ||
| translateY: prev.translateY, | ||
| translateX: 0, |
There was a problem hiding this comment.
What do you think to center the view at the center of the item extent instead of the center of the board? The center of the board could be empty and I think it doesn't really make sense to center in an empty location. Actually look at the PanZoom component, there is this centerBoard function, may be that's exactly what you want to achieve but not only on startup but when we click on a button (which makes a lot of sense).
There was a problem hiding this comment.
Even centering at the center of item extent could be empty. It items are off to the top left and top right (off the board) then centering there would be empty. To recreate that start up the demo, drag half the items off the top left and the other half off the bottom right so they are not visible and center. Nothing will show up even though the view is in the "center" of the objects.
There was a problem hiding this comment.
Even centering at the center of item extent could be empty.
There is probably no perfect solution but at least it should work in most of the real cases. Creating a game with items at opposite of the space without anything in the middle looks slightly unusual don't you think?
At least for now none of the game in ABG are like that and the current centering is working great for all of them.
Actually for legacy reasons part of the games were created when the center was actually the top left corner so for this games chances are great that we don't see anything.
What do you think?
| target | ||
| build | ||
| coverage | ||
| test |
There was a problem hiding this comment.
I have the feeling these lines are duplicated, is there any reason?
There was a problem hiding this comment.
Hit the resolved by accident. Toolset did this again. I'll remove them.
There was a problem hiding this comment.
Have you pushed your changes because I can still see the changes.
| } | ||
|
|
||
| // Limit move to board limit | ||
| const distToCenter = distance(screenCenter, [boardCenter.x, boardCenter.y]); |
There was a problem hiding this comment.
I think with should still keep the board limitations when we don't limit pan otherwise you can see board limit which is not great, what do you think?
There was a problem hiding this comment.
I may be making some really large maps so not limiting at all is helpful for that. I was going to suggest having a background color instead of a base image (which is what I think is currently being done).
I am planning on adding a group of 9 buttons instead of just the center button. Each one would set the view to the top left, top middle, top right, left middle, middle, middle right, left bottom, bottom middle, and bottom right. Based on the positions of all the items added so far. laid out like so.
1 2 3
4 5 6
7 8 9
There was a problem hiding this comment.
I was going to suggest having a background color instead of a base image (which is what I think is currently being done).
Allowing a repetitive background (svg/image/css) was a request from some users and I think it's a good feature so I'm not sure remove that is a good idea.
Regarding what you want, do you know it's possible to save positions with alt+[number key] and restore them with [number key].
We could imagine that the new feature pre-set the positions as you described, what do you think?
There was a problem hiding this comment.
I may be making some really large maps so not limiting at all is helpful for that.
I'm curious to see your game because I imported some of the biggest existing games (using vassal modules) and they all fit in the current board size. I used to play gloomhaven with a lot of space per user and we were really far from reaching the limit. Are you items at the right size? How are they compared to pre-made items?
Also have you noticed that there is a "box" system where you can store your game items when they are not used? May be this will mitigate your need for space? what do you think?
Changes to fix items listed on 3/7/2026
|
New version 002 pushed today for your review. The changes made as commented on. Once those items are resolved I will start adding more functionality. |
There was a problem hiding this comment.
Could you also revert the changes of this file?
Hey I tried to answer to the still open comments. I'd love to hear your thoughts. |
|
Going to be a while. Im busy the next couple weeks.
For centering, I play LARGE miniature war games where the center of the
board is often empty for a good while.
…On Thu, Mar 12, 2026, 1:49 PM Jérémie Pardou ***@***.***> wrote:
*jrmi* left a comment (jrmi/react-sync-board#14)
<#14 (comment)>
New version 002 pushed today for your review. The changes made as
commented on. Once those items are resolved I will start adding more
functionality.
Hey I tried to answer to the still open comments. I'd love to hear your
thoughts.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJ55VVKIDV2ROJ2GJ5LS4L4QL2DBAVCNFSM6AAAAACWESJCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANBYG42TONZSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2 participants
No description provided.