Fix dynamic select storybook test failure #176
Conversation
- Modified `useOnFormValueChange` hook to correctly track `prevValue` using `useRef`. - Updated `selectRadixOption` test helper to blur the trigger after selection (click on body) to simulate "clicking off" and ensure onBlur events fire.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
- Modified `useOnFormValueChange` hook to correctly track `prevValue` using `useRef`. - Updated `AutoCalculation` story to use `waitFor` instead of `setTimeout` to prevent CI race conditions. - Updated `selectRadixOption` test helper to blur the trigger after selection (click on body) to simulate "clicking off" and ensure onBlur events fire.
- Refactored `AutoCalculationExample` story to separate form definition and consumption to stabilize `onChange` and avoid re-subscription loops. - Modified `useOnFormValueChange` hook to correctly track `prevValue` using `useRef` and optimize dependencies. - Updated `AutoCalculation` story to use `waitFor` instead of `setTimeout` to prevent CI race conditions. - Updated `selectRadixOption` test helper to blur the trigger after selection (click on body) to simulate "clicking off" and ensure onBlur events fire.
1 participant
This PR addresses a failing Storybook test for dynamic select dropdowns. The issue was suspected to be related to the test interaction not properly triggering a "blur" event.
Changes:
packages/components/src/remix-hook-form/hooks/use-on-form-value-change.ts: Fixed a bug whereprevValuepassed to theonChangecallback was incorrect (same as current value). UseduseRefto correctly store and retrieve the previous value.apps/docs/src/lib/storybook/test-utils.ts: UpdatedselectRadixOptionhelper to click ondocument.bodyafter selecting an option. This ensures the trigger loses focus, simulating a user clicking off the element, which may be required for certain state updates or validation triggers in the test environment.PR created automatically by Jules for task 5689511453060209533 started by @jaruesink