WIP - A few more consequences of the Namespace#53
Open
PipoCanaja wants to merge 4 commits intolibrenms-plugins:masterfrom
Open
WIP - A few more consequences of the Namespace#53PipoCanaja wants to merge 4 commits intolibrenms-plugins:masterfrom
PipoCanaja wants to merge 4 commits intolibrenms-plugins:masterfrom
Conversation
Contributor
Author
|
Will have to check librenms/librenms#8917 as it may just solve and we revert to the original state. |
PipoCanaja
changed the title
murrant
reviewed
Jul 17, 2018
Weathermap.php
Outdated
| $submenu = ' <ul class="dropdown-menu scrollable-menu">'; | ||
| $count = 0; | ||
|
|
||
| //getShortName - might make sense to include this ShortName code into Plugin class somewhere ? |
Contributor
There was a problem hiding this comment.
You can just use __CLASS__ can't you?
Contributor
Author
|
Ok. Looks much better after the fix librenms/librenms#8917 . Reverting the namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back here. Seems that more changes are needed.
@laf: do you think this is the right way to get the short class name (without namespace) or should it be done another way ?
At least this PR makes Weathermap completely operational now.