Switch stop signal over to tokio::sync::watch::channel#104
Merged
tnull merged 1 commit intolightningdevkit:mainfrom May 23, 2023
Merged
Switch stop signal over to tokio::sync::watch::channel#104tnull merged 1 commit intolightningdevkit:mainfrom
tokio::sync::watch::channel#104tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
wpaulino
reviewed
May 22, 2023
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
LGTM. Will wait to approve until the dependent goes through.
tnull
force-pushed
the
2023-05-switch-stop-signal
branch
2 times, most recently
from
8891816 to
a95aa8a
Compare
tnull
force-pushed
the
2023-05-switch-stop-signal
branch
from
a95aa8a to
3f233dc
Compare
Collaborator
Author
|
Now rebased on main after #85 was merged, squashed the fixup while at it. |
wpaulino
approved these changes
May 23, 2023
joostjager
pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
…ll-request/patch Automated nightly rustfmt (2026-01-19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #85, Prerequisite for #93.