Add OutputSweeper persisting and spending outputs#152
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Dec 11, 2023
Merged
Add OutputSweeper persisting and spending outputs#152tnull merged 2 commits intolightningdevkit:mainfrom
OutputSweeper persisting and spending outputs#152tnull merged 2 commits intolightningdevkit:mainfrom
Conversation
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
5 times, most recently
from
aa6ea5d to
7a976b6
Compare
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
3 times, most recently
from
d285a15 to
e13dc9d
Compare
tnull
changed the title
OutputSweeper persisting and retrying output sweepsOutputSweeper persisting and spending outpu
tnull
changed the title
OutputSweeper persisting and spending outpuOutputSweeper persisting and spending outputs
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
from
e13dc9d to
41687a1
Compare
Collaborator
Author
|
Rebased on main after merging #105. |
wpaulino
reviewed
Aug 14, 2023
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
6 times, most recently
from
52828d1 to
19e55d9
Compare
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
8 times, most recently
from
4111b5d to
54889d8
Compare
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
3 times, most recently
from
d72eec7 to
8ea16da
Compare
Collaborator
Author
|
Started to include some necessary prefactors to allow to test this reasonably. In particular I now moved transaction broadcasting to a |
Collaborator
Author
|
Now split out the prefactors to #205 and rebased this PR on it. |
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
3 times, most recently
from
2090986 to
7619507
Compare
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
2 times, most recently
from
f890ef8 to
59ee5f0
Compare
Collaborator
Author
|
Rebased on #205 and dropped the WIP testing commit. Will add coverage when upstreaming |
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
from
59ee5f0 to
456b6ca
Compare
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
2 times, most recently
from
ac5d405 to
6f98c96
Compare
Collaborator
Author
|
Rebased after #205 landed. |
wpaulino
reviewed
Dec 4, 2023
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
3 times, most recently
from
6305271 to
0f31390
Compare
We add an `OutputSweeper` object that will keep track of sweepable outputs. To this end, we start by adding the general structures and the required utilities to persist the `SpendableOutputStatus` to our `KVStore`.
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
from
0f31390 to
ad072e7
Compare
Collaborator
Author
|
Squashed without further changes. |
tnull
force-pushed
the
2023-08-sweep-sweep-sweep
branch
from
ad072e7 to
707c170
Compare
wpaulino
approved these changes
Dec 11, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #105Closes #94
We add an
OutputSweeperobject that will keep track of spendable outputs. It implementsListen/Confirmand regularly retries to sweep outputs that haven't been spent.