Add VSS Store CI Integ Test#161
Conversation
|
Thanks! Do we see a way to integrate it more closely? In particular, we should run |
There was a problem hiding this comment.
Note that we'll want to run the usual tests against this backend, so while it might be a bit cleaner to have a separate CI worflow, we'll probably need to do this setup as part of our 'regular' CI run, possibly as part of a vss feature flag for now.
There was a problem hiding this comment.
I think we can do this setup in separate workflow and run all tests against it.
I didn't want to bloat single ci workflow so much and wanted to maintain some separation of concerns regarding vss-integration in particular .
Yes, once we have a public api to build with vss, will add that. |
There is no reason to wait for the public API, as we can just use |
|
Depends on lightningdevkit/vss-server#25 |
|
This needs a rebase now that #158 landed :) |
|
Rebased on #158 |
The integration test fails due to: I.e., on |
|
I think this will be fixed once latest vss-client is published(since it depends on some changes in that), i will verify it once. |
|
Depends on #213 for now. |
In this, we spin up a local vss-server instance using tomcat, and run vss related integration tests in ldk-node.
|
@tnull rebased and that error is fixed now. |
tnull
left a comment
There was a problem hiding this comment.
LGTM.
As discussed elsewhere, I'd eventually like to collect all the integration tests under ./tests, but that can happen in the future.
Depends on #158