Draft
Conversation
|
👋 Hi! This PR is now in draft status. |
joostjager
force-pushed
the
test-logging
branch
from
d5bf615 to
4c6f512
Compare
joostjager
force-pushed
the
test-logging
branch
2 times, most recently
from
9eb545e to
042816a
Compare
joostjager
force-pushed
the
test-logging
branch
4 times, most recently
from
bb56249 to
63d53f1
Compare
joostjager
force-pushed
the
test-logging
branch
from
63d53f1 to
afe2cc1
Compare
Contributor
Author
|
Potential problems so far:
|
So that we'll cleanly signal and wait for termination.
Previously ldk-node would start binding after the first successful bind to an address.
joostjager
force-pushed
the
test-logging
branch
3 times, most recently
from
9456b73 to
386e6cb
Compare
To avoid conflicts ("port in use") with ports that were used for
outgoing connections and are now in the TIME_WAIT state.
joostjager
force-pushed
the
test-logging
branch
from
6dbd283 to
92e1208
Compare
Collaborator
|
We decided to make the |
Collaborator
|
@joostjager Can this be closed by now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily to debug the current test flakes in CI, but also for future debugging generally.