Update rust-lightning to fix InvoiceBuilder breakage #783
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Feb 4, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks! You'll need to bump the bitcoin-payment-instructions dependency also to make this build.
| vss-client = { package = "vss-client-ng", version = "0.4" } | ||
| prost = { version = "0.11.6", default-features = false} | ||
| #bitcoin-payment-instructions = { version = "0.6" } | ||
| bitcoin-payment-instructions = { git = "https://github.com/tnull/bitcoin-payment-instructions", rev = "7ee3958834aba575e04b91a862f790d798a7d578" } |
Collaborator
There was a problem hiding this comment.
Please bump this to e4d519b95b26916dc6efa22f8f1cc11a818ce7a7 in order to have the bitcoin-payment-instructions dependency use the same version of lightning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates rust-lightning dependencies to
817ab5e583002df5e32b3a71e7ab093005a2a39a.This fixes the build breakage resulting from the
InvoiceBuilderandPaymentHashrefactor in upstream PR #4363.Specific changes:
Cargo.tomlrevision.Sha256hash inPaymentHashinsrc/liquidity.rsto match the newInvoiceBuilderAPI.