Merged
Conversation
tnull
force-pushed
the
2023-05-stop-on-drop
branch
from
1b56fb6 to
feda4b4
Compare
They are copied/defereneced in most cases anyways, and this makes the interface a bit more uniform.
tnull
force-pushed
the
2023-05-stop-on-drop
branch
from
feda4b4 to
7c067a7
Compare
Collaborator
Author
|
Rebased after #25 has been merged. |
jkczyz
approved these changes
May 9, 2023
|
|
||
| impl Drop for Node { | ||
| fn drop(&mut self) { | ||
| let _ = self.stop(); |
Contributor
There was a problem hiding this comment.
If the node is already stopped, this will return Error::NotRunning. I guess that is ok though.
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's why I'm ignoring the result here.
joostjager
pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
joostjager
pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
Silent merge conflict from lightningdevkit#84, we were not enforcing clippy in CI when this was opened so it never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
We simply call
stop()on dropping theNodeobject to allow for a cleaner shutdown by default.We also include a minor commit which changes the API to take
SocketAddrsandPublicKeys by value as they'll be copied/dereferenced in most cases anyways and this makes the API a tiny bit more uniform.