Adds lightning-transaction-sync in favor of Confirm#251
Adds lightning-transaction-sync in favor of Confirm#251ConorOkus wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| If you are connecting full blocks or using BIP 157/158, then it is recommended to use | ||
| LDK's [`lightning_block_sync`](https://docs.rs/lightning-block-sync/*/lightning_block_sync/) crate as in the example above: the high-level steps that must be done for both `ChannelManager` and each `ChannelMonitor` are as follows: | ||
|
|
||
| 1. Get the last blockhash that each object saw. |
There was a problem hiding this comment.
I think all of the examples given in these steps are bindings-specific and would look differently in Rust.
There was a problem hiding this comment.
Yeah agree, generally speaking, the kotlin & swift examples approach things from a mobile-first perspective but I've not seen any simple examples of CBF in a mobile context yet. Hopefully, with BDK 1.0 it's possible. Current mobile users are opting for Esplora/Electrum and we have some coverage there.
Co-authored-by: Elias Rohrer <dev@tnull.de>
ConorOkus
force-pushed
the
add-lts-example
branch
from
c91ff23 to
4f8109a
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Basically LGTM.
Not sure if we want to hold off merging this until the next bindings release to immediately include the tx-sync examples?
| **What it's used for:** this step is only necessary if you're restarting and have open channels. This step ensures that LDK channel state is up-to-date with the bitcoin blockchain | ||
| **What it's used for:** this step is only necessary if you're restarting and have open channels. This step ensures that LDK channel state is up-to-date with the bitcoin blockchain. | ||
|
|
||
| There are 2 main options for synchronizing to chain on startup: |
There was a problem hiding this comment.
nit: Spell out numbers zero to ten.
Yeah let's hold off for that, sgtm! |
2 participants
Can add examples for kotlin and swift examples once exposed in the bindings.
Also probably worth adding CBF examples once available in BDK 1.0
Closes #249