Remove spurious universality comment on KVStore
#4369
Merged
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There would be nothing wrong with passing a different `KVStore` to `OutputSweeper` from `MonitorUpdatingPersister` (though I'm not really sure why someone would), and in fact I'm not aware of any cases where passing a different `KVStore` to different structs would be problematic. Thus, the sentence in docs is simply removed.
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
valentinewallace
approved these changes
Feb 2, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4369 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 156 156
Lines 102605 102641 +36
Branches 102605 102641 +36
=======================================
+ Hits 88241 88276 +35
- Misses 11854 11858 +4
+ Partials 2510 2507 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There would be nothing wrong with passing a different
KVStoretoOutputSweeperfromMonitorUpdatingPersister(though I'm not really sure why someone would), and in fact I'm not aware of any cases where passing a differentKVStoreto different structs would be problematic. Thus, the sentence in docs is simply removed.