Skip to content

Remove spurious universality comment on KVStore #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Feb 3, 2026
+0 −7
Merged

Remove spurious universality comment on KVStore #4369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lightning/src/util/persist.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,20 +258,13 @@ where
/// namespace, i.e., conflicts between keys and equally named
/// primary namespaces/secondary namespaces must be avoided.
///
/// Instantiations of this trait should generally be shared by reference across the lightning
/// node's components. E.g., it would be unsafe to provide a different [`KVStore`] to
/// [`OutputSweeper`] vs [`MonitorUpdatingPersister`].
///
/// **Note:** Users migrating custom persistence backends from the pre-v0.0.117 `KVStorePersister`
/// interface can use a concatenation of `[{primary_namespace}/[{secondary_namespace}/]]{key}` to
/// recover a `key` compatible with the data model previously assumed by `KVStorePersister::persist`.
///
/// For a synchronous version of this trait, see [`KVStoreSync`].
///
/// This is not exported to bindings users as async is only supported in Rust.
///
/// [`OutputSweeper`]: crate::util::sweep::OutputSweeper
/// [`MonitorUpdatingPersister`]: crate::util::persist::MonitorUpdatingPersister
// Note that updates to documentation on this trait should be copied to the synchronous version.
pub trait KVStore {
/// Returns the data stored for the given `primary_namespace`, `secondary_namespace`, and
Expand Down
Loading