chore: Sync account schemas

[lightspark-copybara]

Auto-synced account schemas.

These schemas are generated from VASP adapter field definitions in sparkcore.

Synced directories:

• common/ — per-currency account info and beneficiary schemas
• external_accounts/ — per-currency external account schemas (reference common/)

Please review the changes before merging.

[greptile-apps]

Greptile Summary

Auto-synced account schemas for 13 new currencies (BRL, DKK, HKD, IDR, INR, MXN, MYR, PHP, SGD, THB, USD, VND) from VASP adapter field definitions. Added new *AccountInfo.yaml and *Beneficiary.yaml files in common/ directory and corresponding *ExternalAccountInfo.yaml files in external_accounts/.

Major changes:

• Added 13 new currency-specific account info schemas with required fields for each currency
• Added 13 new beneficiary schemas with address, tax ID, and user type fields
• Updated existing schemas (GBP, PHP, SGD) to remove validation patterns, examples, and accountType field
• Modified ExternalAccountInfoOneOf.yaml to include references to new currency account types

Critical issue found:

• ExternalAccountInfoOneOf.yaml contains duplicate oneOf entries for 10 existing account types (US, CLABE, PIX, IBAN, UPI, NGN, CAD, GBP, PHP, SGD), which will cause OpenAPI validation failures

Confidence Score: 2/5

• This PR has critical schema validation issues that will break the API specification
• The duplicate oneOf entries in ExternalAccountInfoOneOf.yaml will cause OpenAPI validation to fail when bundling. Additionally, removed validation patterns from existing schemas (GBP, PHP, SGD) eliminate important data validation that was previously enforced.
• Pay immediate attention to openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml which contains duplicate references, and review whether removing validation from GbpAccountInfo.yaml, PhpAccountInfo.yaml, and SgdAccountInfo.yaml is intentional

Important Files Changed

Filename	Overview
openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml	Added new currency account references but created duplicate entries for CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, and US accounts
openapi/components/schemas/common/GbpAccountInfo.yaml	Removed validation patterns, examples, and accountType field; simplified to basic fields only
openapi/components/schemas/common/PhpAccountInfo.yaml	Removed validation, examples, and accountType field; simplified descriptions
openapi/components/schemas/common/SgdAccountInfo.yaml	Removed swiftCode field, validation patterns, examples, and accountType field

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ExternalAccountInfoOneOf] --> B[BaseExternalAccountInfo]
    A --> C[Currency-Specific AccountInfo]
    A --> D[Beneficiary Schema]
    
    C --> C1[BrlAccountInfo]
    C --> C2[DkkAccountInfo]
    C --> C3[GbpAccountInfo]
    C --> C4[HkdAccountInfo]
    C --> C5[IdrAccountInfo]
    C --> C6[InrAccountInfo]
    C --> C7[MxnAccountInfo]
    C --> C8[MyrAccountInfo]
    C --> C9[PhpAccountInfo]
    C --> C10[SgdAccountInfo]
    C --> C11[ThbAccountInfo]
    C --> C12[UsdAccountInfo]
    C --> C13[VndAccountInfo]
    
    D --> D1[Individual Beneficiary]
    D --> D2[Business Beneficiary]
    
    D1 --> D1A[Currency-Specific Beneficiary Schemas]
    D1A --> D1A1[BrlBeneficiary]
    D1A --> D1A2[DkkBeneficiary]
    D1A --> D1A3[GbpBeneficiary]
    D1A --> D1A4[And 10 more...]
    
    style A fill:#ff6b6b
    style C fill:#4ecdc4
    style D fill:#45b7d1

Loading

_{Last reviewed commit: 30b98d2}

[greptile-apps]

_{47 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Duplicate account type references in the oneOf array. The following accounts appear twice with different case conventions:

• "US Account" (line 2) and "Us Account" (line 68)
• "CLABE Account" (line 4) and "Clabe Account" (line 38)
• "PIX Account" (line 6) and "Pix Account" (line 60)
• "IBAN Account" (line 8) and "Iban Account" (line 46)
• "UPI Account" (line 10) and "Upi Account" (line 66)
• "NGN Account" (line 12) and "Ngn Account" (line 56)
• "CAD Account" (line 14) and "Cad Account" (line 36)
• "GBP Account" (line 16) and "Gbp Account" (line 42)
• "PHP Account" (line 18) and "Php Account" (line 58)
• "SGD Account" (line 20) and "Sgd Account" (line 62)

These duplicates will cause schema validation issues. Remove either the old or new entries to maintain only one reference per account type.

Prompt To Fix With AI

This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 2-73

Comment:
Duplicate account type references in the oneOf array. The following accounts appear twice with different case conventions:
- "US Account" (line 2) and "Us Account" (line 68)
- "CLABE Account" (line 4) and "Clabe Account" (line 38)
- "PIX Account" (line 6) and "Pix Account" (line 60)
- "IBAN Account" (line 8) and "Iban Account" (line 46)
- "UPI Account" (line 10) and "Upi Account" (line 66)
- "NGN Account" (line 12) and "Ngn Account" (line 56)
- "CAD Account" (line 14) and "Cad Account" (line 36)
- "GBP Account" (line 16) and "Gbp Account" (line 42)
- "PHP Account" (line 18) and "Php Account" (line 58)
- "SGD Account" (line 20) and "Sgd Account" (line 62)

These duplicates will cause schema validation issues. Remove either the old or new entries to maintain only one reference per account type.

How can I resolve this? If you propose a fix, please make it concise.