feat: increase lieveness probe failureThreshold for apl-operator#3012
Open
j-zimnowoda wants to merge 3 commits intomainfrom
Open
feat: increase lieveness probe failureThreshold for apl-operator#3012j-zimnowoda wants to merge 3 commits intomainfrom
j-zimnowoda wants to merge 3 commits intomainfrom
Conversation
Contributor
|
Comparison of Helm chart templating output: @@ spec.template.spec.containers.apl-operator.livenessProbe.failureThreshold @@
! ± value change
- 1
+ 3
|
CasLubbers
approved these changes
Mar 5, 2026
merll
approved these changes
Mar 9, 2026
Ani1357
reviewed
Mar 9, 2026
Contributor
Ani1357
left a comment
Ani1357
left a comment
There was a problem hiding this comment.
With this change, in case the operator gets stuck, the earlier restart would happen after 18min(15min + 3 X 60s X failureThreshold).
How about lowering the test to check so it tests after 10 min (600s) and keep the failureThreshold at 3, so it takes 13min in the best case. I think after 13min is still reasonable to consider the operator stuck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
The failure threshold is a bit too low to decide if a pod should be killed.
🔍 Reviewer Notes
🧹 Checklist