Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses regression issues in integration tests that were failing due to race conditions when resources (particularly Linodes) were not fully provisioned before being used in tests. The fixes primarily add wait_for_condition calls to ensure resources reach the expected state before proceeding with test operations.
Changes:
- Renamed helper function
create_linodetocreate_linode_functo avoid naming conflict with existing fixture - Added wait conditions to ensure Linodes are in expected states before performing operations
- Fixed import ordering to follow PEP 8 conventions
- Reordered domain test operations to ensure clone completes before verification
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/models/networking/test_networking.py | Renamed create_linode to create_linode_func to avoid fixture name collision; added wait conditions for Linode status in VLAN and IP info tests |
| test/integration/models/linode/test_linode.py | Added wait condition to verify Linode reaches offline status during migration before deletion |
| test/integration/models/domain/test_domain.py | Moved time.sleep(1) before fetching domains to ensure clone operation completes |
| test/integration/models/account/test_account.py | Fixed import ordering to follow PEP 8; added wait condition to ensure Linode is running before checking events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vshanthe
reviewed
Feb 17, 2026
Contributor
vshanthe
left a comment
There was a problem hiding this comment.
LGTM , you can run make lint to fix lint issue
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
Regression fixes for integration tests. Most of the failures were possibly related to long provisioning ([404] Not found)
Jira: https://track.akamai.com/jira/browse/TPT-4203
✔️ How to Test
Integration tests workflow run