Open
Conversation
mgwoj
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Deprecates the xen kernel capability field in the Go SDK model to reflect the upstream API response no longer including it, while keeping the field for backward compatibility.
Changes:
- Adds a Go deprecation comment to the
LinodeKernel.XENfield. - Minor struct field formatting adjustments around
LinodeKernelfields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| KVM bool `json:"kvm"` | ||
| // Deprecated: this field is no longer populated by the API, but it is included here for backward compatibility with existing implementations. | ||
| XEN bool `json:"xen"` | ||
| PVOPS bool `json:"pvops"` |
There was a problem hiding this comment.
This struct field formatting (extra spaces between name/type/tag) likely won’t pass the repo’s enforced gofumpt formatting (CI runs gofumpt -l -w . and fails on diffs). Re-run gofumpt/gofmt so the field alignment matches the rest of the struct.
Suggested change
| PVOPS bool `json:"pvops"` | |
| PVOPS bool `json:"pvops"` |
dawiddzhafarov
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The
xenfield has been removed from the kernel API response. We can deprecate this field from SDKs and tools. https://www.linode.com/docs/api/linode-instances/#kernel-view✔️ How to Test
No changes to the tests.