Don't fail on non-existent plugin directory.#212
Open
JulianGro wants to merge 1 commit intolinuxdeploy:masterfrom
Open
Don't fail on non-existent plugin directory.#212JulianGro wants to merge 1 commit intolinuxdeploy:masterfrom
JulianGro wants to merge 1 commit intolinuxdeploy:masterfrom
Conversation
When no plugins are available, Qt doesn't create a folder for them. For example, Qt might build with printsupport, but not create the printsupport plugins directory, because CUPS isn't installed and no libcupsprintersupport.so plugin was built.
bjorn
reviewed
Feb 26, 2026
Contributor
bjorn
left a comment
There was a problem hiding this comment.
Change looks fine to me, it's good to print warnings regarding this because people may not be aware their Qt could be missing some things (though, this will only get caught when all plugins of a certain type are missing), yet it may also be intentional.
I just wonder if it would be better to report the full missing path rather than just the pluginName?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no plugins are available, Qt doesn't create a folder for them. For example, Qt might build with printsupport, but not create the printsupport plugins directory, because CUPS isn't installed and no libcupsprintersupport.so plugin was built.
Without this patch, packaging fails for me when trying to package Qt provided by Conan:
Granted, this is probably an edge case, since system packages would have the plugins and custom built packages would usually find system CUPS and build the plugin.